-
Notifications
You must be signed in to change notification settings - Fork 22
[release-1.10] NETOBSERV-2401 Static plugin forms polishing #1051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.10] NETOBSERV-2401 Static plugin forms polishing #1051
Conversation
- remove divider, flatten, charts - do not use example as the prepopulated data - few changes in the introduction text (e.g. use "network flows" rather than "flowlogs data"). Mention that FlowCollector is needed.
- Add link to advanced form - Clarify what namespace is expected - Show name/namespace as required
Hi @openshift-cherrypick-robot. Thanks for your PR. I'm waiting for a netobserv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #1051 +/- ##
=============================================
Coverage 53.21% 53.22%
=============================================
Files 205 205
Lines 11109 11110 +1
Branches 1294 1294
=============================================
+ Hits 5912 5913 +1
Misses 4685 4685
Partials 512 512
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This is an automated cherry-pick of #1028
/assign jotak